[
https://issues.apache.org/jira/browse/GOBBLIN-2073?focusedWorklogId=923572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923572
]
ASF GitHub Bot logged work on GOBBLIN-2073:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/24 21:04
Start Date: 14/Jun/24 21:04
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1640354522
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -117,20 +119,29 @@ public static String
createDagActionReminderKey(DagActionStore.DagAction dagActi
dagAction.getFlowExecutionId(), dagAction.getJobName(),
dagAction.getDagActionType());
}
+ /**
+ * Creates a JobKey object for the reminder job where the name is the
DagActionReminderKey from above and the group is
+ * the flowGroup
+ */
+ public static JobKey createJobKey(DagActionStore.DagAction dagAction) {
+ return new JobKey(createDagActionReminderKey(dagAction),
dagAction.getFlowGroup());
Review Comment:
if deadline reminder is still existing, then we shouldn't have retry
reminder in the scheduler at this point. the tagging will be useful if we want
to differentiate them for a diff purpose
Issue Time Tracking
-------------------
Worklog Id: (was: 923572)
Time Spent: 3.5h (was: 3h 20m)
> Add eventTime and reminder fields to DagAction POJO
> ---------------------------------------------------
>
> Key: GOBBLIN-2073
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2073
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> An event timestamp and reminder flag are used in conjunction with DagActions
> for lease arbitration and for reminder dagActions. It makes sense to include
> these fields in the DagAction object itself to easily transfer the
> information from one location to another. In particular for reminder events
> used to check back in on incomplete dagAction leases, these two fields are
> utilized and it's easiest to keep track of them when it's maintained within
> the consensusDagAction returned in a LeaseAttemptStatus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
