[
https://issues.apache.org/jira/browse/GOBBLIN-2073?focusedWorklogId=923566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923566
]
ASF GitHub Bot logged work on GOBBLIN-2073:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/24 19:25
Start Date: 14/Jun/24 19:25
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1640251636
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -80,7 +80,7 @@ public class DagManagementTaskStreamImpl implements
DagManagement, DagTaskStream
protected Optional<DagActionReminderScheduler> dagActionReminderScheduler;
private final boolean isMultiActiveExecutionEnabled;
private static final int MAX_HOUSEKEEPING_THREAD_DELAY = 180;
- private final BlockingQueue<DagActionStore.DagAction> dagActionQueue = new
LinkedBlockingQueue<>();
+ private final BlockingQueue<DagActionStore.LeaseObject> dagActionQueue = new
LinkedBlockingQueue<>();
Review Comment:
should we rename it to leaseObjectQueue ?
Issue Time Tracking
-------------------
Worklog Id: (was: 923566)
Time Spent: 3h 10m (was: 3h)
> Add eventTime and reminder fields to DagAction POJO
> ---------------------------------------------------
>
> Key: GOBBLIN-2073
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2073
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> An event timestamp and reminder flag are used in conjunction with DagActions
> for lease arbitration and for reminder dagActions. It makes sense to include
> these fields in the DagAction object itself to easily transfer the
> information from one location to another. In particular for reminder events
> used to check back in on incomplete dagAction leases, these two fields are
> utilized and it's easiest to keep track of them when it's maintained within
> the consensusDagAction returned in a LeaseAttemptStatus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
