[
https://issues.apache.org/jira/browse/GOBBLIN-2073?focusedWorklogId=923781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923781
]
ASF GitHub Bot logged work on GOBBLIN-2073:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/24 18:55
Start Date: 17/Jun/24 18:55
Worklog Time Spent: 10m
Work Description: umustafi commented on PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#issuecomment-2174209078
> Most of the diff in the PR is because of the refactoring. Can you explain
what were the changes that helped get rid of this todo
>
> ```
> // todo - fix bug of a reminder event getting a lease even when the first
attempt succeeded.
> // for now, avoid processing reminder events if they are not
for deadline dag actions
> ```
yes the main change is storing eventTimestamp from the first
leaseAttemptStatus in the DagActionReminderScheduler and using that when trying
lease on reminder MALA. Otherwise it would use current ts as the eventTimestamp
and treat every reminder as new event and do duplicate processing of dagAction
once for original once for reminder
Issue Time Tracking
-------------------
Worklog Id: (was: 923781)
Time Spent: 4h (was: 3h 50m)
> Add eventTime and reminder fields to DagAction POJO
> ---------------------------------------------------
>
> Key: GOBBLIN-2073
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2073
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> An event timestamp and reminder flag are used in conjunction with DagActions
> for lease arbitration and for reminder dagActions. It makes sense to include
> these fields in the DagAction object itself to easily transfer the
> information from one location to another. In particular for reminder events
> used to check back in on incomplete dagAction leases, these two fields are
> utilized and it's easiest to keep track of them when it's maintained within
> the consensusDagAction returned in a LeaseAttemptStatus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
