[
https://issues.apache.org/jira/browse/GOBBLIN-2104?focusedWorklogId=926428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926428
]
ASF GitHub Bot logged work on GOBBLIN-2104:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 00:59
Start Date: 18/Jul/24 00:59
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3983:
URL: https://github.com/apache/gobblin/pull/3983#discussion_r1681939758
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagProcessingEngineTest.java:
##########
@@ -80,17 +81,17 @@ public void setUp() throws Exception {
doReturn(true).when(dagActionStore).deleteDagAction(any());
dagManagementTaskStream =
new DagManagementTaskStreamImpl(config,
Optional.of(mock(DagActionStore.class)),
- mock(MultiActiveLeaseArbiter.class),
Optional.of(mock(DagActionReminderScheduler.class)), false,
- dagManagementStateStore);
+ mock(MultiActiveLeaseArbiter.class),
Optional.of(mock(DagActionReminderScheduler.class)),
+ false, dagManagementStateStore,
Mockito.mock(DagProcessingEngineMetrics.class));
this.dagProcFactory = new DagProcFactory(null);
DagProcessingEngine.DagProcEngineThread dagProcEngineThread =
new DagProcessingEngine.DagProcEngineThread(dagManagementTaskStream,
this.dagProcFactory,
- dagManagementStateStore, 0);
+ dagManagementStateStore, mock(DagProcessingEngineMetrics.class),
0);
Review Comment:
I'm not sure if we verify metrics being marked all that often in our tests.
It could be checked although seems a bit overkill. I could use Mockito to
verify that the specific metrics marking function is called (success/failed)
for its corresponding case. Is that what you're imagining?
Issue Time Tracking
-------------------
Worklog Id: (was: 926428)
Time Spent: 1h 40m (was: 1.5h)
> Initialize DagProcessingEngine Metrics
> --------------------------------------
>
> Key: GOBBLIN-2104
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2104
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
