[
https://issues.apache.org/jira/browse/GOBBLIN-2104?focusedWorklogId=926566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926566
]
ASF GitHub Bot logged work on GOBBLIN-2104:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 21:16
Start Date: 18/Jul/24 21:16
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3983:
URL: https://github.com/apache/gobblin/pull/3983#discussion_r1683516935
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -220,17 +230,17 @@ private DagTask createDagTask(DagActionStore.DagAction
dagAction, LeaseAttemptSt
switch (dagActionType) {
case ENFORCE_FLOW_FINISH_DEADLINE:
- return new EnforceFlowFinishDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore);
+ return new EnforceFlowFinishDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore, dagProcEngineMetrics);
case ENFORCE_JOB_START_DEADLINE:
- return new EnforceJobStartDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore);
+ return new EnforceJobStartDeadlineDagTask(dagAction,
leaseObtainedStatus, dagManagementStateStore, dagProcEngineMetrics);
case KILL:
- return new KillDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new KillDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
case LAUNCH:
- return new LaunchDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new LaunchDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
case REEVALUATE:
- return new ReevaluateDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new ReevaluateDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
case RESUME:
- return new ResumeDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore);
+ return new ResumeDagTask(dagAction, leaseObtainedStatus,
dagManagementStateStore, dagProcEngineMetrics);
Review Comment:
this does not look good but sadly i do not have any easy alternate
suggestion for dag tasks to have dagProcEngineMetrics
Issue Time Tracking
-------------------
Worklog Id: (was: 926566)
Time Spent: 2h 10m (was: 2h)
> Initialize DagProcessingEngine Metrics
> --------------------------------------
>
> Key: GOBBLIN-2104
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2104
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
