[
https://issues.apache.org/jira/browse/GOBBLIN-2104?focusedWorklogId=926567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926567
]
ASF GitHub Bot logged work on GOBBLIN-2104:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 21:19
Start Date: 18/Jul/24 21:19
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3983:
URL: https://github.com/apache/gobblin/pull/3983#discussion_r1683519715
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/EnforceFlowFinishDeadlineDagProc.java:
##########
@@ -41,8 +44,18 @@ public
EnforceFlowFinishDeadlineDagProc(EnforceFlowFinishDeadlineDagTask enforce
super(enforceFlowFinishDeadlineDagTask);
}
- protected void enforceDeadline(DagManagementStateStore
dagManagementStateStore, Dag<JobExecutionPlan> dag)
- throws IOException {
+ @Override
Review Comment:
i see some opportunity to de-deuplicate code here
you can move this to parent class and have both the child classes implement
abstract method `getDagActionType`
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/EnforceFlowFinishDeadlineDagProc.java:
##########
@@ -41,8 +44,18 @@ public
EnforceFlowFinishDeadlineDagProc(EnforceFlowFinishDeadlineDagTask enforce
super(enforceFlowFinishDeadlineDagTask);
}
- protected void enforceDeadline(DagManagementStateStore
dagManagementStateStore, Dag<JobExecutionPlan> dag)
- throws IOException {
+ @Override
Review Comment:
i see some opportunity to de-deplicate code here
you can move this to parent class and have both the child classes implement
abstract method `getDagActionType`
Issue Time Tracking
-------------------
Worklog Id: (was: 926567)
Time Spent: 2h 20m (was: 2h 10m)
> Initialize DagProcessingEngine Metrics
> --------------------------------------
>
> Key: GOBBLIN-2104
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2104
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
