[
https://issues.apache.org/jira/browse/GOBBLIN-2104?focusedWorklogId=926569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926569
]
ASF GitHub Bot logged work on GOBBLIN-2104:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 21:22
Start Date: 18/Jul/24 21:22
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3983:
URL: https://github.com/apache/gobblin/pull/3983#discussion_r1683522169
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ReevaluateDagProc.java:
##########
@@ -73,6 +75,7 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Pair<Optiona
// dag actions for each of those parallel job and in this scenario there
is no job status available.
// If the job status is not present, this job was never launched, submit
it now.
DagProcUtils.submitJobToExecutor(dagManagementStateStore, dagNode,
getDagId());
+
dagProcEngineMetrics.markDagActionsAct(DagActionStore.DagActionType.REEVALUATE,
true);
Review Comment:
how about all dag procs implement the above mentioned `getDagActionType`
method? looks like the same line can be used in many places
Issue Time Tracking
-------------------
Worklog Id: (was: 926569)
Time Spent: 2.5h (was: 2h 20m)
> Initialize DagProcessingEngine Metrics
> --------------------------------------
>
> Key: GOBBLIN-2104
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2104
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
