autumnust commented on a change in pull request #2856: [GOBBLIN-1011] adjust
compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r360971895
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -473,6 +475,10 @@ public void dropTableIfExists(String dbName, String
tableName) throws IOExceptio
public void dropPartitionIfExists(String dbName, String tableName,
List<Column> partitionKeys,
List<String> partitionValues) throws IOException {
try (AutoReturnableObject<IMetaStoreClient> client =
this.clientPool.getClient()) {
+ if (client.get().getPartition(dbName, tableName, partitionValues) ==
null) {
Review comment:
1. Could you clean up the catch block on `NoSuchObjectException` is you
decide to use existence check instead of relying on the exception to determine
there's no such object ?
2. I am not familiar with this getPartition API but sending a list of
partition values but returning single partition object seems to be a little bit
strange. Can you double check the semantic ? Or alternative there's a
`listPartitions` method which is usually the API that I used for checking
existence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
