zxcware commented on a change in pull request #2856: [GOBBLIN-1011] adjust
compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r360983125
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/task/TaskIFaceWrapper.java
##########
@@ -75,6 +78,8 @@ public String getProgress() {
public void run() {
try {
this.underlyingTask.run();
+ } catch (Exception e) {
+ log.error(String.format("Task %s completed with exception",
this.taskContext.getTaskState().getTaskId()), e);
Review comment:
I found that when `underlyingTask` threw an exception (in my case, it is an
NPE), there was no message at all(the exception got swallowed and didn't get a
chance to be logged while bubbling up) and this wrapper continued to the
`finally` block, marking the task as a success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
