zxcware commented on a change in pull request #2856: [GOBBLIN-1011] adjust
compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r361029573
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -473,6 +475,10 @@ public void dropTableIfExists(String dbName, String
tableName) throws IOExceptio
public void dropPartitionIfExists(String dbName, String tableName,
List<Column> partitionKeys,
List<String> partitionValues) throws IOException {
try (AutoReturnableObject<IMetaStoreClient> client =
this.clientPool.getClient()) {
+ if (client.get().getPartition(dbName, tableName, partitionValues) ==
null) {
Review comment:
Verified with a test job that we also need this catch exception to detect
partition not exist..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
