autumnust commented on a change in pull request #2856: [GOBBLIN-1011] adjust
compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r360972543
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveTable.java
##########
@@ -105,16 +114,21 @@ protected void updateTablePartitionFields(State state,
String key, Object value)
public static class Builder extends HiveRegistrationUnit.Builder<Builder> {
private List<Column> partitionKeys = Lists.newArrayList();
+ private Map<String, String> tableParameters = Maps.newHashMap();
public Builder withPartitionKeys(List<Column> partitionKeys) {
this.partitionKeys = partitionKeys;
return this;
}
+ public Builder withTableParameters(Map<String, String> tableParameters) {
Review comment:
There's reason that TableParameters are not included in the builder: We
internally use some timestamp and record count in the table parameters.
Including these values in the table object could cause diff-check failure and
issue much more updatePartition call in the hive metastore. Could you double
check with the potential write-amplification to relevant team ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
