Hi Justin,

Justin Mclean <jus...@classsoftware.com> 于2024年9月1日周日 22:37写道:

> Hi,
>
> > For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
> > know, Python doesn't support version like "0.6.0-incubating", so I only
> > keep the 0.6.0 delibrately. I also refer to some other incubating
> projects
> > like HugeGraph (https://pypi.org/project/hugegraph-python/#history),
> seems
> > they also don't add the "incubating" in their version.
>
> We must change this (easy enough to do with "svn mv") as all artifacts
> need ”incubating” in their name. See [1] "The release archive(s) MUST
> include the word "incubating" in the filename."
>

This Python package name is generated from Python configuration file and
its version number, we cannot simply rename the package name using mv,
otherwise, it will be failed to upload to Pypi and install.

The only thing we can do is change the version number to "0.6.0.incubating"
("-" is not allowed for Python version numbers) and re-package them. Is the
version number "0.6.0.incubating" ok for you?


>
> >> - The Python client README.md build instruction needs to be updated as
> >> they assume it part of the main gravitino repo
> >>
> >>
> > Python README.md already reflects the Python things including how to
> build
> > Python package, can you please point out what specific issue it is?
>
> Its context is outside of that one artifact, which would be confusing to
> someone who comes across the package on its own. For instance, if I go to
> "Build and testing”, which someone might do when reviewing the artifact,
> and it says "./gradlew :clients:client-python:build”, however that is not
> going to work in this artifact.
>
>
Yeah, the readme is more about how to build from scratch. This Python
package is a release package that can be used directly, no need to compile.
The README can be improved, but it's not a blocking thing here.



> Kind Regards,
> Justin
>
> 1. https://incubator.apache.org/policy/incubation.html#releases
>
>

Reply via email to