Hi, -1 (binding) as some files are misisng incubating in their names, but if those files are renamed, then +1 (binding)
Several LICENSE and NOTICE files need updating, but that’s OK due to the WIP disclaimer. Testing on mocOS I checked: - Not all artifact names include incubating in them, e.g. apache_gravitino-0.6.0.tar.gz. This needs to be fixed, but there is no need for a new RC or vote, just rename the files. - Signatures and hashes are fine. - DISCLAIMER (WIP), NOTICE and LICENSE exist in all artifacts. - The LICENSE and NOTICE is incorrect for apache_gravitino-0.6.0.tar.gz, same with the licenses directory. The LICENSE and NOTICE files need to reflect what is in the release artifact, and it seems the binary LICENSE and NOTICE files for the Java release have been copied here. In this case of the stock LICENSE file, adding "MIT License Copyright (c) 2016 Dhamu” is all that is needed. BTW do we know what project this code comes from? - Similarly, the LICENSE and NOTICE files for gravitino-iceberg-rest-server-0.6.0-incubating-bin and gravitino-trino-connector-0.6.0-incubating need to be updated to reflect what is in them. - The main gravitino LICENSE is missing a license for TCPDS. I couldn't find out this data was licenced from a quick search. Do we know how the data is licensed? - all ASF files have the correct header, although perhaps it could be added to some XML files. - No unexpected binary files in the source release - Compile fails due to rat issues, but can compile from source (and test pass) with the addition of -x rat Other minor issues: - The KEY file needs to be in https://dist.apache.org/repos/dist/release/incubator/gravitino/ - I think gravitino-trino-connector-0.6.0-incubating.tar.gz should include a “-bin” in the name as it’s not source code. Again, this can be renamed without a new RC or vote. - Is the source code for gravitino-trino-connector-0.6.0-incubating and gravitino-iceberg-rest-server-0.6.0-incubating included in the release? (I am asking this in case this comes up in the IPMC vote). - The rat test fails when building the source. The files it fails on are acceptable, except for possibly some XML files. - Do the “.github” and “.gitattributes” files need to be in the source release? - The Python client README.md build instruction needs to be updated as they assume it part of the main gravitino repo Kind Regards, Justin
