Jan Holesovsky wrote:
Hi Kai,(CCing Michael as he is the main 'Industrial' advocate ;) ) On Thu, 28 Jul 2005, Kai Ahrens wrote:From the technical side, I already took a first look at your patches and consider them to be ok. On the other hand, after taking a look at the installed OOo on a GTK desktop (XFCE), I'm not sure, if this CWS is already in a state to be integrated. My point is, that the Industrial theme seems to be (to me) not ready for shipment at all. This is not an art question (although this might be also discussed), but a question of consistency. The whole icon theme seems to be mixed, there are 'grey' icons beside 'blue' icons in oneflyer, and I had the feeling that some icons are just at the wrong position.A screenshot would be very helpful here, I guess. Could you please provide one or two?
Of course. Please take a look at the attached screenshot taken from Impress application. As you can see, there's definitely no consistency in the whole theme regarding the usage of colours in this case and this has been found by me within seconds. Taking a closer look at the high contrast theme was not possible at all for me since I got a kind of eye cancer soon after switching to this theme.
We definitely have to investigate here.The Industrial icons are sized 24x24. May it be that on some places the toolbars are resized according to this size, and elsewhere they are according to the 26x26, the size of the default images?
I don't think that we have a technical problem in this case, it's more a problem of completeness and consistency.
As a conclusion, I consider the current OOo icon theme as the reference theme, so that I really do not recommend the automatic switch as default, which would give us the 'broken' Industrial on many many systems. What do you think regarding this?It is easy to change the default, yes. But is that really that bad? I mean, when someone uses Industrial icon theme for his desktop, I bet that it is much less consistent to have the default OOo icons there, instead of Industrial ones (though grey-blue mixed). Both Gnome Industrial icons andOOo Industrial icons were created by the same artist, AFAIK.I can try to introduce a check for the actual icon theme used, and default to Industrial only if it is really used in the desktop. What do you think?
Yes, I consider this really that bad at the moment. I always thoughtthat we have a highly professional product with OpenOffice and I don't want to have an OOo release where the default icon theme maps to
something that appears to be really hacked, and that was integrated just to have it. This might work and this might make _some_ people happy, but my grandma (if I still had one) would ask me if I were a serious guy or just kidding. Do you really want to see such screenshots in a press review? I do not... - Kai
<<attachment: industrial_inconsistency.jpg>>
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
