Hi Jan (and Michael)!
Jan Holesovsky wrote:
Hi Éric,
I am not sure what do you mean by this. I have provided just the Linux
build (I do not have access to any Windows machine), and the 1.9.x Linux
builds are just .rpm's now, no './setup' there. Check
http://download.openoffice.org/680/index.html, you will see the same.
You're right. I didn't look at a Windows build but remembered having seen
rpms *with* setup files. Sorry for the confusion.
- I installed the CWS on JDS (+ gnome) and, when starting, it tells me
"no suitable windowing system found, exiting." and it does it. Meaning
this CWS doesn't run on JDS (let's see - maybe off list - what's the
problem)
cd /opt/openoffice.org1.9.119/program
ldd libvcl680li.so
ldd libvclplug_gtk680li.so
and check the output for 'not found' and install the missing bits. I
guess it is going to be libstartup-notification; I forgot that I should
build without it, sorry. I do not know JDS, but there should be
possibility to install this library. If not, it should be enough to use
copy it from any Linux distro available.
If the above is true, and the build works with the fixed dependency,
it's not fault of the CWS, but mine when I was building it---I forgot to
switch the libstartup-notification support off.
Ok I added 2 libs and it works now (same problem on JDS and SuSE 9
Enterprise):
libstartup-notification-1.so.0
libsndfile.so.1
AFAIK, on Linux, it is just checked that the average color of OOo is
darker than some value and then HC is used. That could be improved as
well, but in a separate CWS, I guess.
I guess we completely agree here ;-) As it is now, when OOo runs in HC
mode with 'Automatic' in the theme selection list box, the HiContrast
icons are used by regardless of the desktop the user is running; just
because we do not have 'HiContrast Industrial'.
That's exactly what I meant this way: we *must* have an HIContrast
industrial theme which will not be available in the option listbox but
will be switched automatically when chosing High Contrast at system level.
AFAIK Industrial is the typical Gnome icon theme and especially Gnome
supports real High Contrast (Not only black and white colors).
So we have to keep consistency when we can.
It's ok to implement this in an other CWS but keep in mind that it's an
accessibility *requirement* (this is a legal issue in some countries,
including U.S.A. ...) to have HC icons.
But when she _decided_ to choose another theme, this is her choice, and
we should provide her the freedom of choice.
If we give the possibility to the user to add *her own* themes, it's ok.
But, at least, I consider that the themes (Industrial, Crystal?, Mono?)
we (will) deliver have to be HC compliant.
Icons stuff:
- Available Themes: they are not all complete (not all icons available)
Can you be more specific here? What icons are missing? Do you have a
screenshot, please?
The small icons Kai was refering to, for instance.
They have to be consistent to match the quality level we need to
integrate the CWS.
If you are talking about Crystal and Mono, yes, they are incomplete.
But this CWS does neither contains them, nor enable them.
Right! My fault! Sorry!
But then you have to remove the references to Crystal from the main
section of the spec and mention it only under "Future Tasks".
- Industrial Theme: It's *definitively* not a question of taste (I
like that theme a lot!) but there are still some icons that are not
really readable (A11y again)... AAA, AAA (Bold, Italic, Underlines,
Font/Character/Paragraph background) for instance...
We should contact the artist here I guess.
But I'd like to separate the CWS and the artwork here. I think that
when I change the behaviour so that the brand new OOo always defaults to
the OOo's default icon set, we could solve such issues later. What do
you think?
Ok.
The Spec:
- General : a lot of areas don't fit with spec requirements (we can
discuss it off list). The Spec cannot be final while all people didn't
say "approved". And nobody from the written people said it untill
now... ;)
Sorry, I misunderstood the meaning of this. I thought it is that the
people were approved to do the implementation, not that the
specification has been approved by the listed people. (The label says
just 'Approved for Implementation' and there is a list of people without
further explanation...)
Indeed, the "Approved" referes to the spec's text, not to the simple
project of doing something ;)
Why is a spec important for a new feature?
- because it defines what the program does *and does not*!
- because it is a reference for people who want to know "why".
From this point of view,
I tried my best to write a good specification; but it was my first OOo
specification, so please be patient ;-)
I am! :)
Please don't take my remarks as blockers or nagging assertions (keep in
mind I'm not an native English speaker, so both words and culture may
not be yours but I do my best! ;) ).
My only goal is to get the best quality into OOo and there are some
work-flows to respect to achieve this goal. Please ask me any time if
you have doubts or need help!
I don't see the spec as "ok" right now
Please check
http://specs.openoffice.org/ui_in_general/icons/icon-theme-switching.sxw
Is it better now when I added screenshots and fixed the 'approved' section?
Yes, it's *much* better but...
I'll send you a "Spec sample" with comments + your spec with comments.
I know, writing a spec may be pretty boring and it's not your job (not
mine too). But writing a good spec is not a pure bureaucraty job but
will prevent us from getting bug reports. If we all have, before
implementing, a strong brain-storming which the spec reflects, we can
expect to make the best design for this feature and just having to say:
"not a bug. Works as designed" and direct issues to "enhancements".
Thank you,
Thank *you* for the great work you've done on that feature I love!
And sorry if though I cannot give my "go" yet...
Ciao
Éric
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
