mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add timezone to client handshake URL: https://github.com/apache/guacamole-server/pull/219#discussion_r272822672
########## File path: src/libguac/guacamole/user.h ########## @@ -537,32 +544,6 @@ void guac_user_free(guac_user* user); */ int guac_user_handle_connection(guac_user* user, int usec_timeout); -/** - * Call the appropriate handler defined by the given user for the given - * instruction. A comparison is made between the instruction opcode and the - * initial handler lookup table defined in user-handlers.c. The intial handlers - * will in turn call the user's handler (if defined). - * - * @param user - * The user whose handlers should be called. - * - * @param opcode - * The opcode of the instruction to pass to the user via the appropriate - * handler. - * - * @param argc - * The number of arguments which are part of the instruction. - * - * @param argv - * An array of all arguments which are part of the instruction. - * - * @return - * Non-negative if the instruction was handled successfully, or negative - * if an error occurred. - */ -int guac_user_handle_instruction(guac_user* user, const char* opcode, Review comment: > Should I just copy it instead of move it ... I think the best route would be: * Keep the new version of `guac_user_handle_instruction()` but rename it such that it can exist as an internal function which doesn't collide with the existing `guac_user_handle_instruction()`. * Invoke the new version from the old function such that `guac_user_handle_instruction()` continues to work, yet primarily exists in one place. > ... and mark this for deprecation? I'm not 100% on that. If we will be removing this function, it does need to be deprecated first, but should it be removed? It seems a useful counterpart to `guac_parser`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
