mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r275086395
##########
File path: src/protocols/kubernetes/settings.c
##########
@@ -25,6 +25,14 @@
/* Client plugin arguments */
const char* GUAC_KUBERNETES_CLIENT_ARGS[] = {
+ /**
+ * This first argument defines the protocol version in use so that the
+ * client knows how to handle talking to different versions of guacd.
+ * If this is omitted the client may choose not to enable certain
+ * features.
+ */
+ "VERSION_1_1_0",
Review comment:
Side note: even if it proves inconvenient to fully verify the argument count
outside the protocol implementation (doing so would require iterating through
the args until we find the `NULL`), we _do_ know that any conforming Guacamole
implementation will provide at least one argument value because
`guac_protocol_send_args()` will now always send at least one argument value
(the version), so lacking at least one value within the received `args` would
be a protocol violation.
We could, of course, choose to be tolerant of that, leave total rejection up
to the protocol implementation, and handle the lack of even one argument value
as equivalent to leaving that initial value blank.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
