mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r278344894
##########
File path: src/libguac/user-handshake.c
##########
@@ -219,7 +162,8 @@ static void* guac_user_input_thread(void* data) {
guac_error_message = NULL;
/* Call handler, stop on error */
- if (guac_user_handle_instruction(user, parser->opcode, parser->argc,
parser->argv) < 0) {
+ if (__guac_user_call_opcode_handler(__guac_instruction_handler_map,
+ user, parser->opcode, parser->argc, parser->argv) < 0) {
Review comment:
Did you mean:
if (__guac_user_call_opcode_handler(__guac_instruction_handler_map,
user, parser->opcode, parser->argc, parser->argv)) {
?
`__guac_user_call_opcode_handler()` may use positive values as failure, as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
