mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r275083334
##########
File path: src/protocols/kubernetes/settings.c
##########
@@ -25,6 +25,14 @@
/* Client plugin arguments */
const char* GUAC_KUBERNETES_CLIENT_ARGS[] = {
+ /**
+ * This first argument defines the protocol version in use so that the
+ * client knows how to handle talking to different versions of guacd.
+ * If this is omitted the client may choose not to enable certain
+ * features.
+ */
+ "VERSION_1_1_0",
Review comment:
> Is there a way to do this outside of the protocol-specific parameter
parser?
Yes. There's no protocol specific parser - the Guacamole protocol requires
that the `connect` instruction include a value for each argument declared in
`args`, in the same order as specified in `args`.
Regardless of the protocol implementation, the Guacamole protocol would
guarantee one of the following has to be true:
1. The client side is an up-to-date implementation and will populate that
initial `VERSION_1_1_0` argument with its own protocol version.
2. The client side is older and will interpret `VERSION_1_1_0` as the
literal name of an argument. As that argument presumably does not exist and
does not have a value, it will be blank in the reponse.
3. The client does not correctly implement the Guacamole protocol and the
argument count does not match (the server should close the connection at this
point as all bets are off).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
