necouchman commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r273890163
##########
File path: src/protocols/kubernetes/settings.c
##########
@@ -25,6 +25,14 @@
/* Client plugin arguments */
const char* GUAC_KUBERNETES_CLIENT_ARGS[] = {
+ /**
+ * This first argument defines the protocol version in use so that the
+ * client knows how to handle talking to different versions of guacd.
+ * If this is omitted the client may choose not to enable certain
+ * features.
+ */
+ "VERSION_1_1_0",
Review comment:
> This would remain VERSION_1_1_0 even after guacamole-server is at 1.2.0,
1.3.999, etc., being a reference to the protocol variation introduced by the
release having that same version number?
I don't have a strong preference either way, but that would be fine with me.
Unless you think it adds confusion to have the protocol version follow the
product version? I think it would be okay, as it would establish the minimum
software version for each of the protocol features, which seems reasonably to
me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
