necouchman commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r275073419
##########
File path: src/protocols/kubernetes/settings.c
##########
@@ -25,6 +25,14 @@
/* Client plugin arguments */
const char* GUAC_KUBERNETES_CLIENT_ARGS[] = {
+ /**
+ * This first argument defines the protocol version in use so that the
+ * client knows how to handle talking to different versions of guacd.
+ * If this is omitted the client may choose not to enable certain
+ * features.
+ */
+ "VERSION_1_1_0",
Review comment:
> Could be as simple as:
> Verifying receipt of the expected number of arguments
> Storing argv[0] somewhere sensible in guac_user
> Using argc - 1 and argv + 1 for the call to guac_client_add_user()
Is there a way to do this outside of the protocol-specific parameter parser?
The expected number of arguments will vary protocol-to-protocol, so is there a
way to know prior to the `guac_client_add_user()` call what the `parser->argc`
value should be, and whether or not to subtract from `argc` and do `argv + 1`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
