necouchman commented on a change in pull request #219: GUACAMOLE-422: Add 
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r277074067
 
 

 ##########
 File path: src/libguac/user-handshake.c
 ##########
 @@ -290,7 +234,11 @@ int guac_user_handle_connection(guac_user* user, int 
usec_timeout) {
 
     guac_socket* socket = user->socket;
     guac_client* client = user->client;
-
+    
+    user->info.audio_mimetypes = NULL;
+    user->info.image_mimetypes = NULL;
+    user->info.video_mimetypes = NULL;
 
 Review comment:
   We can definitely do that, here.  It doesn't break things to not have it, 
here, because the `free()` call is just a standard call rather than a loop that 
goes through a pointer array, as in the case of the audio, image, and video 
mimetypes.  But it's trivial to initialize it, so I'll add that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to