necouchman commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r274651571
##########
File path: src/protocols/kubernetes/settings.c
##########
@@ -25,6 +25,14 @@
/* Client plugin arguments */
const char* GUAC_KUBERNETES_CLIENT_ARGS[] = {
+ /**
+ * This first argument defines the protocol version in use so that the
+ * client knows how to handle talking to different versions of guacd.
+ * If this is omitted the client may choose not to enable certain
+ * features.
+ */
+ "VERSION_1_1_0",
Review comment:
Okay, I think I've managed to accomplish this. Only odd thing at this
point is that, when both client and server are updated, I see the following
message in the server log:
guacd[35020]: DEBUG: Parameter "(null)" omitted. Using default value
of "America/New_York".
Is there something else I need to do on the receiving side to pull this off
correctly so that it doesn't end up as a `null` parameter? It seems to work
okay - the timezone is getting set - but the message indicates something isn't
quite right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
