mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r278346143
##########
File path: src/libguac/user-handshake.c
##########
@@ -305,104 +310,20 @@ int guac_user_handle_connection(guac_user* user, int
usec_timeout) {
guac_parser* parser = guac_parser_alloc();
- /* Get optimal screen size */
- if (guac_parser_expect(parser, socket, usec_timeout, "size")) {
-
- /* Log error */
+ /* Perform the handshake with the client. */
+ if (__guac_user_handshake(user, parser, usec_timeout)) {
guac_user_log_handshake_failure(user);
guac_user_log_guac_error(user, GUAC_LOG_DEBUG,
- "Error reading \"size\"");
-
+ "Error while reading opcode instruction.");
Review comment:
"opcode instruction" doesn't make sense (all Guacamole instructions have
opcodes and there isn't some class of instruction called an opcode
instruction). "Instruction opcode" might, if that's where the failure lies, but
I don't think the cause of the failure is known at this level.
This may not be necessary to log here if `__guac_user_handshake()` already
logs the cause of failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
