mike-jumper commented on a change in pull request #419: GUACAMOLE-302:
Incorrect password field focus
URL: https://github.com/apache/guacamole-client/pull/419#discussion_r296849633
##########
File path: guacamole/src/main/webapp/app/login/directives/login.js
##########
@@ -102,6 +102,13 @@ angular.module('login').directive('guacLogin', [function
guacLogin() {
*/
$scope.submitted = false;
+ /**
+ * The field that needs to be focused
Review comment:
JSDoc comments need to end with a period.
> The field that needs to be focused
This feels too tightly coupled to the actual internal implementation. It is
ultimately used to focus a field, yes, but I don't think this level of things
should be aware of that. The property is named nicely based on its high-level
use: `relevantField`. Is there a better way to phrase this which captures that
high-level intent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
