mike-jumper commented on a change in pull request #419: GUACAMOLE-302:
Incorrect password field focus
URL: https://github.com/apache/guacamole-client/pull/419#discussion_r296881451
##########
File path: guacamole/src/main/webapp/app/form/templates/timeZoneField.html
##########
@@ -3,12 +3,14 @@
<!-- Available time zone regions -->
<select class="time-zone-region"
ng-disabled="disabled"
+ guac-focus="focused"
ng-model="region"
ng-options="name for name in regions | orderBy: name"></select>
<!-- Time zones within selected region -->
<select class="time-zone"
ng-disabled="disabled || !region"
+ guac-focus="focused"
Review comment:
Having `guac-focus="focused"` for both `<select>` fields doesn't make sense,
as you can only have one field focused at a time. What is the intended effect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
