mike-jumper commented on a change in pull request #419: GUACAMOLE-302:
Incorrect password field focus
URL: https://github.com/apache/guacamole-client/pull/419#discussion_r296850423
##########
File path: guacamole/src/main/webapp/app/login/directives/login.js
##########
@@ -102,6 +102,13 @@ angular.module('login').directive('guacLogin', [function
guacLogin() {
*/
$scope.submitted = false;
+ /**
+ * The field that needs to be focused
+ *
+ * @type Field
+ */
+ $scope.relevantField = {};
Review comment:
`{}` is not a `Field` and will also fail simple tests for whether the value
has been set (`{}` is truthy). If you're looking for a default value prior to
actual assignment later, `null` would be a better choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
