mike-jumper commented on a change in pull request #419: GUACAMOLE-302:
Incorrect password field focus
URL: https://github.com/apache/guacamole-client/pull/419#discussion_r296884066
##########
File path: guacamole/src/main/webapp/app/login/directives/login.js
##########
@@ -188,17 +197,37 @@ angular.module('login').directive('guacLogin', [function
guacLogin() {
// Clear all remaining fields that are not username fields
angular.forEach($scope.remainingFields, function
clearEnteredValueIfPassword(field) {
-
+
// If field is not username field, delete it.
if (field.type !== Field.Type.USERNAME && field.name
in $scope.enteredValues)
delete $scope.enteredValues[field.name];
-
+
});
+
Review comment:
Not a deal-breaker, but if you can, I suggest rebasing away these whitespace
changes. I'm not sure where they came from, but they don't appear related to
the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
