mike-jumper commented on a change in pull request #449: Modify the start time of the history session to match the GUAC_DATE and GUAC_TIME in the parameter tokens URL: https://github.com/apache/guacamole-client/pull/449#discussion_r334257112
########## File path: Dockerfile ########## @@ -45,6 +45,9 @@ COPY guacamole-docker/bin/ /opt/guacamole/bin/ COPY . "$BUILD_DIR" # Run the build itself +RUN ["chmod", "777", "/opt/guacamole/bin/build-guacamole.sh"] +RUN ["chmod", "777", "/opt/guacamole/bin/start.sh"] Review comment: These changes would also add far more permissions to the scripts than they should be given. The build and startup scripts definitely do not need to be world-writable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
