mike-jumper commented on a change in pull request #449: Modify the start time
of the history session to match the GUAC_DATE and GUAC_TIME in the parameter
tokens
URL: https://github.com/apache/guacamole-client/pull/449#discussion_r334257328
##########
File path:
guacamole/src/main/java/org/apache/guacamole/tunnel/StandardTokenMap.java
##########
@@ -73,7 +73,7 @@
* The date format that should be used for the time token. This format must
* be compatible with Java's SimpleDateFormat.
*/
- private static final String TIME_FORMAT = "HHmmss";
+ private static final String TIME_FORMAT = "HHmmss-SSS";
Review comment:
I agree that this change need to be justified.
Assuming we do want such a token, it will probably need to be a different
token. Modifying a well-established token to use a different format will result
in breakage in downstream systems that rely on the format of the old token.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
