mike-jumper commented on a change in pull request #449: Modify the start time
of the history session to match the GUAC_DATE and GUAC_TIME in the parameter
tokens
URL: https://github.com/apache/guacamole-client/pull/449#discussion_r334257267
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java
##########
@@ -392,7 +395,29 @@ private GuacamoleSocket getUnconfiguredGuacamoleSocket(
public ConnectionCleanupTask(ActiveConnectionRecord activeConnection) {
this.activeConnection = activeConnection;
}
-
+
+
+
+ /***
+ * @Author zero
+ * @Description 将活动会话记录里的 会话开始时间变更为GUAC_DATE,GUAC_TIME
+ * @InitDate 10:53 2019/10/12
+ * @Param [activeConnection, tokens]
+ **/
+ public ConnectionCleanupTask(ActiveConnectionRecord
activeConnection,Map<String ,String > tokens) {
+ this.activeConnection = activeConnection;
+
+ String yearMonthDay = tokens.get("GUAC_DATE");
+ String hourMinSecMs = tokens.get("GUAC_TIME");
+ SimpleDateFormat simpleDateFormat=new
SimpleDateFormat("yyyyMMddHHmmss-SSS");
Review comment:
I agree. I don't think this is the approach we should take. The history and
tokens should be made to be consistent with each other, but we shouldn't be
parsing tokens as a means of determining when a connection started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
