mike-jumper commented on a change in pull request #449: Modify the start time
of the history session to match the GUAC_DATE and GUAC_TIME in the parameter
tokens
URL: https://github.com/apache/guacamole-client/pull/449#discussion_r334257308
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/ActiveConnectionRecord.java
##########
@@ -211,6 +211,10 @@ public void init(RemoteAuthenticatedUser user,
this.connectionID = activeConnection.getConnectionID();
}
+ public void setStartDate(Date startDate) {
Review comment:
If this approach moves forward and `ActiveConnectionRecord` does need to be
mutable, then this new function needs to be documented.
That said, I don't believe we should use this approach. Connection records
should be immutable, as they are meant to be a reliable snapshot of history.
Rather than create a record with the wrong date and correct that date later by
parsing tokens, the correct date should be used from the start.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
