mike-jumper commented on a change in pull request #228: GUACAMOLE-221: Implement guacd support for prompting URL: https://github.com/apache/guacamole-server/pull/228#discussion_r370970739
########## File path: src/libguac/protocol.c ########## @@ -961,6 +961,37 @@ int guac_protocol_send_rect(guac_socket* socket, } +static int __guac_protocol_send_required(guac_socket* socket, Review comment: Please document this function. Also if sending a NULL-terminated array of strings as a series of instruction elements is common here (it looks like we've done this with at least `args` and `connect`, as well), I think it's worth considering whether we should extract the commonality so there is one internal function leveraged by all three, similar to how we have `__guac_socket_write_length_string()` and `__guac_socket_write_length_int()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
