mike-jumper commented on a change in pull request #228: GUACAMOLE-221: Implement guacd support for prompting URL: https://github.com/apache/guacamole-server/pull/228#discussion_r370971307
########## File path: src/protocols/rdp/rdp.h ########## @@ -48,6 +48,21 @@ #include <pthread.h> #include <stdint.h> +/** + * A flag for tracking if we are waiting conditionally on a username. + */ +#define GUAC_RDP_COND_FLAG_USERNAME 1 + +/** + * A flag for tracking if we are waiting conditionally on a password. + */ +#define GUAC_RDP_COND_FLAG_PASSWORD 2 + +/** + * A flag for tracking if we are waiting conditionally on a domain. + */ +#define GUAC_RDP_COND_FLAG_DOMAIN 3 Review comment: Since 3 is represented in binary as `11`, it cannot be safely used as the value of a bitwise flag intended to represent a state independent of the other flags. They would all need to be powers of two. I think you meant 4 here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
