mike-jumper commented on a change in pull request #228: GUACAMOLE-221:
Implement guacd support for prompting
URL: https://github.com/apache/guacamole-server/pull/228#discussion_r370971377
##########
File path: src/protocols/ssh/ssh.h
##########
@@ -89,6 +89,12 @@ typedef struct guac_ssh_client {
* Lock dictating access to the SSH terminal channel.
*/
pthread_mutex_t term_channel_lock;
+
+ /**
+ * Condition used when SSH client thread needs to wait for Guacamole
+ * client response.
Review comment:
Same here - I think the usage of this condition should much more specific
than an arbitrary client response of some unknown kind. It would be better to
be explicit in the naming and documentation of this and its corresponding flags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
