mike-jumper commented on a change in pull request #228: GUACAMOLE-221:
Implement guacd support for prompting
URL: https://github.com/apache/guacamole-server/pull/228#discussion_r370971349
##########
File path: src/protocols/rdp/rdp.h
##########
@@ -166,6 +181,17 @@ typedef struct guac_rdp_client {
* reallocated during reconnection.
*/
pthread_mutex_t rdp_lock;
+
+ /**
+ * Condition which is used when the pthread needs to wait for a
+ * particular condition to be met.
Review comment:
That particular condition needs to be pretty well defined, at least on our
part, for waiting on this condition to make sense. If this condition and the
associated flags are to be used for requesting arguments, for requesting
credentials, etc. we can make this much clearer by specifically intending them
for that use and documenting them as such.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
