mike-jumper commented on a change in pull request #256: GUACAMOLE-951: Add
ability to set KeyboardType for FreeRDP
URL: https://github.com/apache/guacamole-server/pull/256#discussion_r377298585
##########
File path: src/protocols/rdp/keymap.h
##########
@@ -103,6 +103,24 @@ struct guac_rdp_keymap {
*/
const UINT32 freerdp_keyboard_layout;
+ /**
+ * FreeRDP keyboard type definition.
Review comment:
If the keyboard layout, type, subtype, etc. are Windows/RDP standard values
and not specific to FreeRDP, perhaps we should take this opportunity to move
away from `freerdp_keyboard_layout`, `freerdp_keyboard_type`, etc. here (and
`freerdp` within the keymaps) and migrate to naming that isn't tied to the
underlying RDP implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
