mather commented on a change in pull request #256: GUACAMOLE-951: Add ability
to set KeyboardType for FreeRDP
URL: https://github.com/apache/guacamole-server/pull/256#discussion_r378049450
##########
File path: src/protocols/rdp/settings.c
##########
@@ -1189,6 +1189,9 @@ void guac_rdp_push_settings(guac_client* client,
rdp_settings->DesktopHeight = guac_settings->height;
rdp_settings->AlternateShell =
guac_rdp_strdup(guac_settings->initial_program);
rdp_settings->KeyboardLayout =
guac_settings->server_layout->freerdp_keyboard_layout;
+ rdp_settings->KeyboardType =
guac_settings->server_layout->freerdp_keyboard_type;
+ rdp_settings->KeyboardSubType =
guac_settings->server_layout->freerdp_keyboard_subtype;
+ rdp_settings->KeyboardFunctionKey =
guac_settings->server_layout->freerdp_keyboard_function_key;
Review comment:
Sorry, it should not be set if no value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
