mike-jumper commented on a change in pull request #256: GUACAMOLE-951: Add
ability to set KeyboardType for FreeRDP
URL: https://github.com/apache/guacamole-server/pull/256#discussion_r381070916
##########
File path: src/protocols/rdp/keymap.h
##########
@@ -103,6 +103,24 @@ struct guac_rdp_keymap {
*/
const UINT32 freerdp_keyboard_layout;
+ /**
+ * FreeRDP keyboard type definition.
Review comment:
Yes, I would say so. With three new layout-related members being added here,
if `freerdp_` is not an appropriate prefix, then it shouldn't be used for the
new members, and the older, existing member should be corrected to follow the
new convention. The member in question is not part of a public API, and
avoiding the rename would amount to technical debt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
