mike-jumper commented on a change in pull request #256: GUACAMOLE-951: Add
ability to set KeyboardType for FreeRDP
URL: https://github.com/apache/guacamole-server/pull/256#discussion_r381071918
##########
File path: src/protocols/rdp/settings.c
##########
@@ -1189,9 +1189,15 @@ void guac_rdp_push_settings(guac_client* client,
rdp_settings->DesktopHeight = guac_settings->height;
rdp_settings->AlternateShell =
guac_rdp_strdup(guac_settings->initial_program);
rdp_settings->KeyboardLayout =
guac_settings->server_layout->freerdp_keyboard_layout;
- rdp_settings->KeyboardType =
guac_settings->server_layout->freerdp_keyboard_type;
- rdp_settings->KeyboardSubType =
guac_settings->server_layout->freerdp_keyboard_subtype;
- rdp_settings->KeyboardFunctionKey =
guac_settings->server_layout->freerdp_keyboard_function_key;
+ if (guac_settings->server_layout->freerdp_keyboard_type > 0) {
Review comment:
Seeing as the value being compared is a `UINT32`, testing that the value is
non-zero would be more appropriate. The value can't be negative.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
