echu2013 commented on a change in pull request #547:
URL: https://github.com/apache/guacamole-client/pull/547#discussion_r450918107
##########
File path: guacamole/src/main/webapp/app/client/controllers/clientController.js
##########
@@ -44,6 +44,16 @@ angular.module('client').controller('clientController',
['$scope', '$routeParams
var requestService = $injector.get('requestService');
var tunnelService = $injector.get('tunnelService');
var userPageService = $injector.get('userPageService');
+
+ /**
+ * Counter and limiter for maximum auto-reconnect attempts that we
should
+ * automatically try to establish a connection when
CLIENT_AUTO_RECONNECT or
+ * TUNNEL_AUTO_RECONNECT error types occur.
+ *
+ * @type Number
+ */
+ var AUTO_RECONNECT_TRY = 0;
+ var AUTO_RECONNECT_MAXTRY = 4;
Review comment:
> Yes, we definitely won't need to modify guacamole-server, as the
connection attributes all stay on the guacamole-client side and are available
via the REST API. However, there will be some changes required to the various
Java classes in guacamole-client, along with the JDBC extensions, to support
storage of the attributes.
I pretend not to modify any schema. Is it OK to use
`guacamole_connection_attribute` to store these parameters? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
