necouchman commented on a change in pull request #547:
URL: https://github.com/apache/guacamole-client/pull/547#discussion_r451471717
##########
File path: guacamole/src/main/webapp/app/client/controllers/clientController.js
##########
@@ -44,6 +44,16 @@ angular.module('client').controller('clientController',
['$scope', '$routeParams
var requestService = $injector.get('requestService');
var tunnelService = $injector.get('tunnelService');
var userPageService = $injector.get('userPageService');
+
+ /**
+ * Counter and limiter for maximum auto-reconnect attempts that we
should
+ * automatically try to establish a connection when
CLIENT_AUTO_RECONNECT or
+ * TUNNEL_AUTO_RECONNECT error types occur.
+ *
+ * @type Number
+ */
+ var AUTO_RECONNECT_TRY = 0;
+ var AUTO_RECONNECT_MAXTRY = 4;
Review comment:
I was thinking of this similar in light of the VNC `autoretry`
parameter, but maybe the goals and implementation details are slightly
different. I guess that parameter does the retries transparently in the
background (guacd side), while to the client it only looks like a single
connection attempt. There was mention when implementing WoL support
(GUACAMOLE-513) of the possibility of supporting `autoretry` with some
configurable timers/limits across the board.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
