mike-jumper commented on a change in pull request #547:
URL: https://github.com/apache/guacamole-client/pull/547#discussion_r453233606
##########
File path: guacamole/src/main/webapp/app/client/controllers/clientController.js
##########
@@ -44,6 +44,16 @@ angular.module('client').controller('clientController',
['$scope', '$routeParams
var requestService = $injector.get('requestService');
var tunnelService = $injector.get('tunnelService');
var userPageService = $injector.get('userPageService');
+
+ /**
+ * Counter and limiter for maximum auto-reconnect attempts that we
should
+ * automatically try to establish a connection when
CLIENT_AUTO_RECONNECT or
+ * TUNNEL_AUTO_RECONNECT error types occur.
+ *
+ * @type Number
+ */
+ var AUTO_RECONNECT_TRY = 0;
+ var AUTO_RECONNECT_MAXTRY = 4;
Review comment:
> So, you intend to extend this `guacamole_connection` table columns:
>
> in order to include "reconnection" parameters?
Not exactly. This would be the correct approach if standard attributes are
going to be used here, but I strongly wish to avoid this.
> Or, do you have another idea?
Yes, [listed above in an earlier
comment](https://github.com/apache/guacamole-client/pull/547#discussion_r451290773).
Specifically:
1. Modifying the handling of automatic reconnect such that extensions can
easily override it. An extension could then add this functionality, and any
attributes used would not need to be standardized.
2. Avoiding the issue entirely by ensuring that automated reconnect attempts
are not sufficient to prevent a session from expiring.
I would lean toward the latter (ensuring automated reconnect attempts do not
prevent a session from expiring). It avoids schema changes, API changes, and
any additional configuration, and instead simply leverages existing behavior to
solve the issue motivating GUACAMOLE-1126.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
