necouchman commented on a change in pull request #547:
URL: https://github.com/apache/guacamole-client/pull/547#discussion_r451083056
##########
File path: guacamole/src/main/webapp/app/client/controllers/clientController.js
##########
@@ -44,6 +44,16 @@ angular.module('client').controller('clientController',
['$scope', '$routeParams
var requestService = $injector.get('requestService');
var tunnelService = $injector.get('tunnelService');
var userPageService = $injector.get('userPageService');
+
+ /**
+ * Counter and limiter for maximum auto-reconnect attempts that we
should
+ * automatically try to establish a connection when
CLIENT_AUTO_RECONNECT or
+ * TUNNEL_AUTO_RECONNECT error types occur.
+ *
+ * @type Number
+ */
+ var AUTO_RECONNECT_TRY = 0;
+ var AUTO_RECONNECT_MAXTRY = 4;
Review comment:
I would think we would want to add a couple of fields to the DB schema,
here, similar to the other standard connection attributes. the
`guacamole_connection_attribute` table is more intended for arbitrary
attributes that someone might implement as part of an additional extension that
needs to store data, while the main connection attributes tend to be stored as
columns within the `guacamole_connection` table itself.
I suppose we could look at making the connection attributes behave more like
connection parameters, where they are all stored in the
`guacamole_connection_attributes` table, but that would definitely be a change
to the way it is implemented today.
@mike-jumper Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
