myjimmy commented on a change in pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#discussion_r547297801
##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -283,7 +283,8 @@ static UINT
guac_rdp_cliprdr_format_list(CliprdrClientContext* cliprdr,
if (guac_rdp_cliprdr_format_supported(format_list, CF_TEXT))
return guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_TEXT);
- /* Ignore any unsupported data */
+ /* Suppose that any unsupported data is raw data (in this case, CF_RAW) */
+ guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_RAW);
Review comment:
> why are we requesting that the RDP server send us that data?
Because we need to reset the local clipboard. That's, to get the opportunity
to reset the local clipboard when users copy any data other than text.
The added new code of `guac_rdp_cliprdr_format_list()` function let the
remote server to call `guac_rdp_cliprdr_format_data_response()` function
according to **"Remote Desktop Protocol: Clipboard Virtual Channel Extension"**.
If users copy any kind of data other than text, so we can use
`guac_rdp_cliprdr_format_data_response()` function to reset the local clipboard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
