myjimmy commented on a change in pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#discussion_r547306132
##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -283,7 +283,8 @@ static UINT
guac_rdp_cliprdr_format_list(CliprdrClientContext* cliprdr,
if (guac_rdp_cliprdr_format_supported(format_list, CF_TEXT))
return guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_TEXT);
- /* Ignore any unsupported data */
+ /* Suppose that any unsupported data is raw data (in this case, CF_RAW) */
+ guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_RAW);
Review comment:
In the Apache Guacamole, the process related to the clipboard has one
cyclic loop.
If the remote clipboard is changed, the content of the remote clipboard is
reflected in the local clipboard.
This produces one regression to reflect the local clipboard to the remote
clipboard, again.
So, I thought that we have to reset the local clipboard when copying any
data other than text in the remote server.
Then, we can check the length of the local clipboard in
`guac_rdp_clipboard_end_handler()` function to decide whether we maintain the
clipboard content of the remote server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
