necouchman commented on a change in pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#discussion_r546251100
##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -614,6 +619,11 @@ int guac_rdp_clipboard_end_handler(guac_user* user,
guac_stream* stream) {
if (clipboard == NULL)
return 0;
+ /* Don't need to send it to the remote server, if the local clipboard is
+ * empty */
+ if (clipboard->clipboard->length == 0)
+ return 0;
Review comment:
I'm not sure this logic is correct. What if someone wants to clear the
clipboard and zero it out, removing all contents?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
