mike-jumper commented on a change in pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#discussion_r547886760



##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -614,6 +619,11 @@ int guac_rdp_clipboard_end_handler(guac_user* user, 
guac_stream* stream) {
     if (clipboard == NULL)
         return 0;
 
+    /* Don't need to send it to the remote server, if the local clipboard is
+     * empty */
+    if (clipboard->clipboard->length == 0)
+        return 0;

Review comment:
       It looks like it can:
   
   https://www.windowscentral.com/how-clear-clipboard-data-shortcut-windows-10
   
   Testing the suggestion at the link above (running `echo off | clip` from 
within the Windows command line), that does indeed clear the clipboard, and 
Guacamole currently handles that correctly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to