mike-jumper commented on a change in pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#discussion_r548476115
##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -614,6 +619,11 @@ int guac_rdp_clipboard_end_handler(guac_user* user,
guac_stream* stream) {
if (clipboard == NULL)
return 0;
+ /* Don't need to send it to the remote server, if the local clipboard is
+ * empty */
+ if (clipboard->clipboard->length == 0)
+ return 0;
Review comment:
Yes. In response to Nick noting that this change would remove the
ability for a user to clear the remote clipboard, you said:
> No, it can never happen. I think that we don't need to update the remote
clipboard when there is no data in the local clipboard.
On the contrary, from the above link:
* It can happen.
* It is desirable to be able to do so for the sake of privacy.
If the local clipboard is intentionally cleared, the remote clipboard needs
to be cleared, as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
