jmuehlner commented on code in PR #796:
URL: https://github.com/apache/guacamole-client/pull/796#discussion_r1119189226
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -82,17 +83,12 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
// If the clipboard data is a string, render it as text
if (typeof data.data === 'string')
- element.value = data.data;
+ $scope.clipboardData = data.data;
// Ignore other data types for now
};
- // Update the internally-stored clipboard data when events are fired
- // that indicate the clipboard field may have been changed
- element.addEventListener('input', updateClipboardData);
Review Comment:
Hey so, looking back at this - the reason these were initially done this
way, with the direct DOM access in the controller - was part of an attempt to
allow rich text content in the clipboard (formatting, images, etc).
Obviously it doesn't currently support that, but the current changes in this
PR would have to be undone if we want to try to go down that road again. For
that reason, I think we should just stick with the existing logic for updating
the clipboard contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
